[0.9.1] [BUGFIX] support mtp in disaggregated-prefill scenario #2444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two bug fixes to support MTP speculative decoding in a disaggregated prefill scenario. In vllm_ascend/attention/mla_v1.py, the calculation of actual_seq_lengths_q is corrected for torchair graph mode. In vllm_ascend/worker/model_runner_v1.py, the attention state is correctly set to SpecDecoding for deepseek_mtp in cases where it would have been misidentified as DecodeOnly. The changes are correct and well-targeted. I have no further suggestions.
JC-ut0
force-pushed
the
v0.9.1-dev
branch
3 times, most recently
from
d02aff1 to
ebe1b95
Compare
wangxiyuan
approved these changes
Aug 20, 2025
|
please update the commit message |
Signed-off-by: xuyexiong <[email protected]>
…m-project#1921)" This reverts commit 1cb7b10. Signed-off-by: xuyexiong <[email protected]>
wangxiyuan
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
support mtp in disaggregated-prefill scenario
Does this PR introduce any user-facing change?
No
How was this patch tested?