-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Frontend] supports deepseekv32 chat template #29837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Frontend] supports deepseekv32 chat template #29837
Conversation
|
This pull request has merge conflicts that must be resolved before it can be |
0adbd49 to
2b37523
Compare
|
@chaunceyjiang seems we need a new tool_call parser, are you planning to do this? if not, I can take it. |
|
This pull request has merge conflicts that must be resolved before it can be |
71577ed to
c519bdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
yeqcharlotte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add test_input..json and test_output..txt in unit tests https://huggingface.co/deepseek-ai/DeepSeek-V3.2-Speciale/tree/main/encoding
|
@chaunceyjiang the function call content in this PR is: but the official format looks like seems missing several dsml token: |DSML| |
63c0a39 to
ddf01e7
Compare
@Xu-Wenqing Fixed. PTAL. |
|
Hi, I use I also tried to use |
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
f77c09b to
171ce8c
Compare
Purpose
Test Plan
Result
Test tool call
Result
Test reasoning:
Result :
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.