feat: Add DataDependency v1alpha1 API and generated client code #199
Conversation
|
Welcome @fx147! |
Summary of ChangesHello @fx147, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the new DataDependency v1alpha1 API into the volcano.sh/apis repository, along with all necessary generated client code. This foundational work is essential for enabling data-aware scheduling capabilities within Volcano and represents a significant step in refactoring API definitions into a dedicated repository, enhancing the overall architecture and reusability of components. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the DataDependency v1alpha1 API, along with its generated client code. The changes are well-structured and follow standard practices for adding new APIs to a Kubernetes-style project. I've identified a few areas for improvement, primarily related to consistency in the API type definitions in pkg/apis/datadependency/v1alpha1/types.go to enhance clarity and prevent potential issues. Specifically, I've pointed out inconsistencies in JSON tags and comments versus field types. Additionally, a minor documentation update in pkg/apis/datadependency/v1alpha1/doc.go is suggested for accuracy. The rest of the changes, including the client generation and refactoring of existing code, look good.
|
@fx147 Please resolve conflicts and check gemini's review opinion |
fx147
force-pushed
the
feature/add-datadependency-api
branch
from
0d1af85 to
e02492f
Compare
fx147
force-pushed
the
feature/add-datadependency-api
branch
2 times, most recently
from
d2c14c9 to
fb4334b
Compare
|
@fx147 Please squash your commits into only one clean commit |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add API definitions for the datadependency v1alpha1 API group: - DataSource: represents a cached query result for data sources in federated environment - DataSourceClaim: represents a claim for data source resources Signed-off-by: FanXu <[email protected]>
- Generate deepcopy methods for DataSource and DataSourceClaim types - Generate clientset, informers, listers and apply configurations - Update existing client utilities to support datadependency API group Signed-off-by: FanXu <[email protected]>
fx147
force-pushed
the
feature/add-datadependency-api
branch
from
fb4334b to
b258027
Compare
|
/lgtm |
4 participants
Summary
This PR adds the DataDependency v1alpha1 API definitions and generated client code to the volcano.sh/apis repository as part of the CRD migration from volcano-global.
Changes
API Definitions: Added DataDependency CRD definitions under
pkg/apis/datadependency/v1alpha1/types.go: Core DataSource and DataSourceClaim typesdoc.go: Package documentation and API group definitionregister.go: Scheme registration and GroupVersionKind setupzz_generated.deepcopy.go: Generated DeepCopy methodsGenerated Client Code: Added complete client-go style generated code
pkg/client/clientset/versioned/: Typed clientset for DataDependency APIspkg/client/informers/externalversions/: Shared informer factory and informerspkg/client/listers/datadependency/v1alpha1/: Listers for efficient local cachingAPI Group Details
datadependency.volcano.shv1alpha1DataSource: Represents cached query results for data-aware schedulingDataSourceClaim: Represents claims for data sources with specific requirementsMigration Context
This is part of the broader effort to separate API definitions from the main volcano-global repository to improve modularity and reusability. The DataDependency API enables data-aware scheduling capabilities in Volcano.
Breaking Changes
None - this is a new addition to the apis repository.
Dependencies
feature: implement data-aware dependency scheduling framework with Amoro plugin supportFeature/dsc controller
This PR should be merged before updating volcano-global to use the new API location.