-
Notifications
You must be signed in to change notification settings - Fork 50
Added Responsiveness to Pages #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added Responsiveness to Pages #178
Conversation
|
Welcome @Mohit-Davar! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Mohit-Davar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented a series of changes across the frontend to significantly improve the application's responsiveness, ensuring a seamless user experience on various devices, from large desktop monitors to small mobile phones. The core focus was on adapting page layouts, navigation, data tables, and interactive components to gracefully adjust to different screen sizes, eliminating horizontal scrolling and optimizing element placement for readability and usability.
Highlights
- Page Layout Adaptation: I've updated the main page containers for Jobs, Pods, and Queues to use responsive padding and ensure they fit within the viewport, preventing horizontal scrolling on smaller screens.
- Responsive Sidebar Navigation: The sidebar navigation now intelligently switches from a permanent, always-visible state to a temporary, slide-out drawer on mobile devices, significantly improving usability on smaller screens. It also automatically closes when a menu item is clicked.
- Adaptive Pagination Controls: All pagination components (Jobs, Pods, Queues) have been refactored to dynamically adjust their layout (e.g., stacking elements vertically) based on screen size, ensuring a clear and functional pagination experience on mobile.
- Table Responsiveness and Readability: The Job, Pod, and Queue tables now maintain a minimum width and utilize full available width, with improved header styling and element wrapping, to ensure data remains readable and accessible even on narrower viewports.
- Component-Level Styling Refinements: Minor adjustments were made to the search bar's maximum width and the layout of stat cards and bar charts to ensure consistent and aesthetically pleasing display across various devices.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively introduces responsiveness to various pages, including Jobs, Queues, and Pods, as well as the main layout. The changes primarily leverage Material-UI's useMediaQuery hook and responsive sx properties to adapt the layout for mobile devices, which is well done. I've identified a couple of areas for improvement: one regarding potentially redundant UI logic in the main layout's navigation drawer, and another for enhancing consistency in pagination controls on mobile.
|
Hi, please sign off your commit with |
Signed-off-by: Mohit Davar <[email protected]>
Signed-off-by: Mohit Davar <[email protected]>
0a56c58 to
1b1c130
Compare
Thanks for the heads-up! I've updated the commits. Let me know if anything else is needed. |
|
@Monokaix - Could you provide an update on this PR? |
Fixes : #153
before :
Untitled.video.-.Made.with.Clipchamp.1.mp4
after :
After.mp4