Redesigned the Jobs and Pods layout to align with the Queue structure. #80

Shrutim1505 · 2025-04-08T14:57:14Z

Updated the UI of Jobs and Pods pages to align with the Queue layout.
Improved structure, spacing, and action buttons for better usability.

Shrutim1505 · 2025-04-08T14:59:00Z

This PR is only mergable after #71

Shrutim1505 · 2025-04-08T15:05:34Z

/assign @william-wang

Shrutim1505 · 2025-04-16T20:55:51Z

i will have to redo rendering of this pages too, after the latest changes

Shrutim1505 · 2025-04-23T12:06:55Z

@Monokaix @JesseStutler this branch can be merged now

JesseStutler · 2025-04-27T02:43:26Z

What is this PR for? More description needs to be added in this PR

Shrutim1505 · 2025-04-27T16:46:39Z

What is this PR for? More description needs to be added in this PR

done

de6p

Looking at the code, I noticed it could be made more compact by using TanStack Table. Right now, we're using the MUI library for that. This is just a suggestion — we can implement it later if needed.

TanStack Table generally offers better performance for very large dataset and it's very optimized.

Lightweight Core is very small (~14kb)
// @JesseStutler @Monokaix

JesseStutler · 2025-04-28T06:25:17Z

After I fetch your code and build images, I deploy the dashboard. The pod is keeping crashing:

And the log of backend container is:

Could you help to figure out?

Shrutim1505 · 2025-04-28T07:54:21Z

Looking at the code, I noticed it could be made more compact by using TanStack Table. Right now, we're using the MUI library for that. This is just a suggestion — we can implement it later if needed.

TanStack Table generally offers better performance for very large dataset and it's very optimized.

actually after implementation i will change UI to shadecnUI so i will make necessary changes later

Shrutim1505 · 2025-04-28T07:56:36Z

@JesseStutlerin this PR there is no changes in backend as of now ... only frontend changes are mentioned

Monokaix · 2025-04-28T09:34:41Z

Looking at the code, I noticed it could be made more compact by using TanStack Table. Right now, we're using the MUI library for that. This is just a suggestion — we can implement it later if needed.

TanStack Table generally offers better performance for very large dataset and it's very optimized.

Lightweight Core is very small (~14kb) // @JesseStutler @Monokaix

MUI is a littele an old style, maybe we can change to a more modern one after this LFX project done.

de6p · 2025-04-28T09:57:18Z

Looking at the code, I noticed it could be made more compact by using TanStack Table. Right now, we're using the MUI library for that. This is just a suggestion — we can implement it later if needed.
TanStack Table generally offers better performance for very large dataset and it's very optimized.
Lightweight Core is very small (~14kb) // @JesseStutler @Monokaix

MUI is a littele an old style, maybe we can change to a more modern one after this LFX project done.

we could utilize this pr

Monokaix · 2025-04-28T10:52:29Z

Looking at the code, I noticed it could be made more compact by using TanStack Table. Right now, we're using the MUI library for that. This is just a suggestion — we can implement it later if needed.
TanStack Table generally offers better performance for very large dataset and it's very optimized.
Lightweight Core is very small (~14kb) // @JesseStutler @Monokaix

MUI is a littele an old style, maybe we can change to a more modern one after this LFX project done.

we could utilize this pr

Nice! You can keep working on that: )

JesseStutler · 2025-04-29T03:08:54Z

/lgtm

Monokaix · 2025-05-07T01:27:53Z

frontend/src/components/jobs/JobTable/JobEditDialog.jsx

+
+    const convertContent = (content, fromMode, toMode) => {
+        try {
+            if (fromMode === "yaml" && toMode === "json") {


Both json and yaml are not user friendly, I think we can just keep one yaml format, and add a text box display method to display some important fields instead of json, but this can be done in another pr and not so urgent, and just remove json in this pr: )

Shrutim1505 · 2025-05-07T10:59:25Z

cc @Monokaix @JesseStutler

Signed-off-by: Shruti78 <[email protected]> Frontend updation of the Queues UI Signed-off-by: Shruti78 <[email protected]> Frontend updation of the Queues UI Signed-off-by: Shruti78 <[email protected]> modified jobs-pods for the UI Signed-off-by: Shruti78 <[email protected]> prettier check added Signed-off-by: Shrutim1505 <[email protected]> edit dialogue box changed Signed-off-by: Shrutim1505 <[email protected]> pods handle search improved Signed-off-by: Shrutim1505 <[email protected]> npm run format Signed-off-by: Shrutim1505 <[email protected]>

JesseStutler · 2025-05-13T01:24:50Z

/lgtm

Monokaix · 2025-05-13T02:00:52Z

/approve

volcano-sh-bot · 2025-05-13T02:01:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Monokaix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot requested review from Monokaix and wangyang0616 April 8, 2025 14:57

volcano-sh-bot added the size/XXL label Apr 8, 2025

Shrutim1505 mentioned this pull request Apr 8, 2025

☂ Umbrella issue: Track of Volcano Dashboard Feature Enhancements(LFX'25 term 1) #57

Closed

13 tasks

volcano-sh-bot assigned william-wang Apr 8, 2025

Shrutim1505 marked this pull request as draft April 16, 2025 20:56

Shrutim1505 marked this pull request as ready for review April 23, 2025 10:18

Shrutim1505 force-pushed the modified/jobs-pods branch 4 times, most recently from 26dc5c7 to 4156173 Compare April 23, 2025 12:06

Shrutim1505 changed the title ~~Modification of jobs and pods according to queues~~ Redesigned the Jobs and Pods layout to align with the Queue structure. Apr 27, 2025

Shrutim1505 mentioned this pull request Apr 27, 2025

Backend delete functionality with queues #81

Closed

de6p reviewed Apr 28, 2025

View reviewed changes

volcano-sh-bot assigned JesseStutler Apr 29, 2025

volcano-sh-bot added the lgtm label Apr 29, 2025

Monokaix reviewed May 7, 2025

View reviewed changes

volcano-sh-bot removed the lgtm label May 7, 2025

Shrutim1505 force-pushed the modified/jobs-pods branch from 0b31db2 to 40ca5bb Compare May 8, 2025 06:15

Shrutim1505 mentioned this pull request May 8, 2025

Frontend: Create Functionality for Pods/Queues and Jobs #88

Merged

Shrutim1505 force-pushed the modified/jobs-pods branch from 8e53632 to 540e82f Compare May 12, 2025 20:10

Shrutim1505 force-pushed the modified/jobs-pods branch from 5fb2148 to f1e0644 Compare May 12, 2025 20:11

volcano-sh-bot added the lgtm label May 13, 2025

volcano-sh-bot added the approved label May 13, 2025

volcano-sh-bot merged commit bad5ca3 into volcano-sh:main May 13, 2025
3 checks passed

de6p mentioned this pull request May 21, 2025

[LFX 2025 Term2]Enhance Volcano Dashboard UX and Functionality volcano-sh/volcano#4277

Open

rooty0 mentioned this pull request May 27, 2025

Jobs tab namespace selection broken #159

Open

Redesigned the Jobs and Pods layout to align with the Queue structure. #80

Redesigned the Jobs and Pods layout to align with the Queue structure. #80

Uh oh!

Conversation

Shrutim1505 commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shrutim1505 commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shrutim1505 commented Apr 8, 2025

Uh oh!

Shrutim1505 commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shrutim1505 commented Apr 23, 2025

Uh oh!

JesseStutler commented Apr 27, 2025

Uh oh!

Shrutim1505 commented Apr 27, 2025

Uh oh!

de6p left a comment

Choose a reason for hiding this comment

Uh oh!

JesseStutler commented Apr 28, 2025

Uh oh!

Shrutim1505 commented Apr 28, 2025

Uh oh!

Shrutim1505 commented Apr 28, 2025

Uh oh!

Monokaix commented Apr 28, 2025

Uh oh!

de6p commented Apr 28, 2025

Uh oh!

Monokaix commented Apr 28, 2025

Uh oh!

JesseStutler commented Apr 29, 2025

Uh oh!

Monokaix May 7, 2025

Choose a reason for hiding this comment

Uh oh!

Shrutim1505 May 7, 2025

Choose a reason for hiding this comment

Uh oh!

Shrutim1505 commented May 7, 2025

Uh oh!

JesseStutler commented May 13, 2025

Uh oh!

Monokaix commented May 13, 2025

Uh oh!

volcano-sh-bot commented May 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Shrutim1505 commented Apr 8, 2025 •

edited

Loading

Shrutim1505 commented Apr 8, 2025 •

edited

Loading

Shrutim1505 commented Apr 16, 2025 •

edited

Loading