-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
feat(vapor): forwarded slots #13408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vapor): forwarded slots #13408
Conversation
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
340d140 to
1854562
Compare
b5f3287 to
1b849a3
Compare
1b849a3 to
c23d635
Compare
4565cf0 to
68577ca
Compare
68577ca to
dcf927f
Compare
bd32ec4 to
8df4184
Compare
8aca259 to
385c21e
Compare
385c21e to
7cfec7f
Compare
Size ReportBundles
Usages
|
6dfc12d to
e92244e
Compare
Maximum call stack size exceededoccurredPlayground with this PR
foois a forwarded slot, it is executed, thecurrentInstanceincreateSlotis the instance ofComp, but it should be the instance ofComp1.Therefore, we need to preserve the current component's instance for forwarded slots and use it in
createSlot, similar to howwithCtxworks in VDOM slots. With this PR, the compiled code changes to:Inside the
forwardedSlotCreator, thecurrentInstanceis retained and a function is returned, which calls createSlot and passes the retained instance.Note
This PR includes #13669