fix(compiler-core): identifiers in function parameters should not be inferred as references #13548

zhiyuanzmj · 2025-07-01T08:45:59Z

;(({ title }) => [])
   // ^^^ should not be inferred as references

Summary by CodeRabbit

Bug Fixes
- Improved detection of referenced identifiers in object destructuring patterns, ensuring more accurate handling in code analysis.
Tests
- Added new tests to verify correct identification of referenced identifiers within destructured function parameters.

…inferred as references

coderabbitai · 2025-07-01T08:46:05Z

Walkthrough

The changes update the logic in isReferencedIdentifier to improve detection of referenced identifiers within object destructuring patterns. The function now considers the grandparent node and refines handling of ObjectProperty nodes. Corresponding tests were added to ensure identifiers in destructured function parameters are not incorrectly marked as referenced.

Changes

File(s)	Change Summary
packages/compiler-core/src/babelUtils.ts	Refined `isReferencedIdentifier` logic for object destructuring by passing grandparent node and updating `ObjectProperty` handling.
packages/compiler-core/tests/utils.spec.ts	Added test suite verifying identifiers in destructured function parameters are not marked as referenced.

Suggested labels

ready to merge, :hammer: p3-minor-bug

Poem

In the warren of code, where patterns entwine,
A rabbit hopped through destructures, so fine.
With grandparent in tow, it checked every name—
Are you referenced, or just part of the game?
Now tests are in place, and bugs out of sight,
The code hops ahead, all logic just right! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b0b5d1 and 891d806.

📒 Files selected for processing (1)

packages/compiler-core/__tests__/utils.spec.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/compiler-core/tests/utils.spec.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Redirect rules
GitHub Check: Header rules
GitHub Check: Pages changed

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-07-01T08:47:40Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13548

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13548

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13548

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13548

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13548

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13548

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13548

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13548

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13548

vue

npm i https://pkg.pr.new/vue@13548

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13548

commit: 891d806

github-actions · 2025-07-01T08:49:27Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.3 kB	34.5 kB
vue.global.prod.js	159 kB	58.5 kB	52 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.5 kB	18.2 kB	16.7 kB
createApp	54.5 kB	21.2 kB	19.4 kB
createSSRApp	58.7 kB	22.9 kB	20.9 kB
defineCustomElement	59.4 kB	22.8 kB	20.8 kB
overall	68.5 kB	26.4 kB	24 kB

packages/compiler-core/__tests__/utils.spec.ts

edison1105 · 2025-07-01T12:49:27Z

/ecosystem-ci run

vue-bot · 2025-07-01T12:56:54Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
language-tools	✅ success	✅ success
pinia	✅ success	✅ success
router	✅ success	✅ success
nuxt	✅ success	❌ failure
vitepress	✅ success	✅ success
quasar	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
vue-macros	✅ success	❌ failure
vue-i18n	✅ success	✅ success
vuetify	✅ success	✅ success
radix-vue	✅ success	✅ success
vant	✅ success	❌ failure
primevue	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success
test-utils	✅ success	✅ success
vueuse	✅ success	✅ success

fix(compiler-core): Identifiers in function parameters should not be …

2483aa7

…inferred as references

zhiyuanzmj mentioned this pull request Jul 1, 2025

fix: identifiers in function parameters should not be inferred as references sxzz/ast-kit#113

Merged

zhiyuanzmj changed the title ~~fix(compiler-core): Identifiers in function parameters should not be inferred as references~~ fix(compiler-core): identifiers in function parameters should not be inferred as references Jul 1, 2025

chore: typo

7b0b5d1

sxzz reviewed Jul 1, 2025

View reviewed changes

packages/compiler-core/__tests__/utils.spec.ts Show resolved Hide resolved

chore: add expect.assertions(4)

891d806

sxzz approved these changes Jul 1, 2025

View reviewed changes

edison1105 added ready to merge The PR is ready to be merged. scope: compiler 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Jul 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(compiler-core): identifiers in function parameters should not be inferred as references #13548

fix(compiler-core): identifiers in function parameters should not be inferred as references #13548

zhiyuanzmj commented Jul 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 1, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

Uh oh!

edison1105 commented Jul 1, 2025

Uh oh!

vue-bot commented Jul 1, 2025

Uh oh!

Uh oh!

Uh oh!

fix(compiler-core): identifiers in function parameters should not be inferred as references #13548

Are you sure you want to change the base?

fix(compiler-core): identifiers in function parameters should not be inferred as references #13548

Conversation

zhiyuanzmj commented Jul 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 1, 2025

Size Report

Bundles

Usages

Uh oh!

Uh oh!

edison1105 commented Jul 1, 2025

Uh oh!

vue-bot commented Jul 1, 2025

Uh oh!

Uh oh!

zhiyuanzmj commented Jul 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Jul 1, 2025 •

edited

Loading