perf(shared): use loose equality in isObject for better performance

[ilyaliao]

This PR changes the null check in isObject from val !== null to val != null to achieve a slight performance improvement.

During the validation process, this approach allows us to filter out both null and undefined values in a single comparison before proceeding with the typeof check, making the overall validation more efficient.

IMO, undefined can be filtered out early in this process. Please let me know if I'm wrong.

[coderabbitai]

Walkthrough

The implementation of the isObject function was updated to use a loose inequality check, so it now excludes both null and undefined values when determining if a value is an object. No changes were made to the function's signature or to other parts of the codebase.

Changes

File	Change Summary
packages/shared/src/general.ts	Updated isObject to exclude both null and undefined using val != null instead of val !== null.

Poem

A tweak to what objects truly are,
Now null and undefined won’t get far.
With != null, the check is neat,
Only real objects get a seat.
In code we trust, with bouncy cheer,
The rabbit hops—no nulls in here! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eca0e1c and 34d7300.

📒 Files selected for processing (1)

• packages/shared/src/general.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Redirect rules
• GitHub Check: Header rules
• GitHub Check: Pages changed

🔇 Additional comments (1)

packages/shared/src/general.ts (1)

53-54: LGTM! Solid performance optimization.

The change from strict (!==) to loose (!=) equality is functionally equivalent but more efficient. The loose equality val != null filters out both null and undefined in a single comparison, allowing the function to short-circuit earlier for undefined values without needing the typeof check.

This is a common JavaScript pattern for null/undefined checks and makes the intent clearer while providing the performance benefit described in the PR.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[skirtles-code]

Would you be able to create a benchmark that shows this is faster? Specifically, I think a benchmark should consider a variety of values, as the coercion could potentially slow things down in case where the value isn't undefined.