-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
fix(compiler-vapor): fix asset import from public directory #13630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gianthard-cyh
wants to merge
3
commits into
vuejs:minor
Choose a base branch
from
Gianthard-cyh:minor
base: minor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+107
−13
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
packages/compiler-vapor/__tests__/__snapshots__/compile.spec.ts.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
import { BindingTypes, type RootNode } from '@vue/compiler-dom' | ||
import { type CompilerOptions, compile as _compile } from '../src' | ||
import { compileTemplate } from '@vue/compiler-sfc' | ||
|
||
// TODO This is a temporary test case for initial implementation. | ||
// Remove it once we have more comprehensive tests. | ||
|
@@ -262,4 +263,46 @@ describe('compile', () => { | |
) | ||
}) | ||
}) | ||
|
||
describe('asset imports', () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A new test file should be created to test
Try to port the relevant test cases from the existing |
||
const compileWithAssets = (template: string) => { | ||
const { code } = compileTemplate({ | ||
vapor: true, | ||
id: 'test', | ||
filename: 'test.vue', | ||
source: template, | ||
transformAssetUrls: { | ||
base: 'base/', | ||
includeAbsolute: true, | ||
}, | ||
}) | ||
return code | ||
} | ||
|
||
test('from public directory', () => { | ||
const code = compileWithAssets(`<img src="/foo.svg" />`) | ||
expect(code).matchSnapshot() | ||
expect(code).contains(`import _imports_0 from '/foo.svg';`) | ||
}) | ||
|
||
test(`multiple public assets`, () => { | ||
const code = compileWithAssets( | ||
`<img src="/foo.svg" /> | ||
<img src="/bar.svg" />`, | ||
) | ||
expect(code).matchSnapshot() | ||
expect(code).contains(`import _imports_0 from '/foo.svg';`) | ||
expect(code).contains(`import _imports_1 from '/bar.svg';`) | ||
}) | ||
|
||
test(`hybrid assets`, () => { | ||
const code = compileWithAssets( | ||
`<img src="/foo.svg" /> | ||
<img src="./bar.svg" />`, | ||
) | ||
expect(code).matchSnapshot() | ||
expect(code).contains(`import _imports_0 from '/foo.svg';`) | ||
expect(code).contains(`src=\\"base/bar.svg\\"`) | ||
}) | ||
}) | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be done like this to avoid
renderEffect
andsetProp
.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the suggestion — I’ve tried to move
_imports_0
into the template string as recommended to avoidrenderEffect
andsetProp
.core/packages/compiler-vapor/src/generators/template.ts
Lines 7 to 20 in 65abd6e
However, the
genTemplates
function still usesJSON.stringify()
, which wraps the entire template in double quotes and escapes inner quotes. That prevents me from generating template literals like:I also tried string concatenation:
But this results in a normal string with escaped quotes.
Let me know if you have any thoughts or preferred direction on this — happy to collaborate on the final approach!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be easier to implement using string concatenation. For example, like this: