💄 update reverse array example to modern syntax #3268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggest `arr.toReversed()` instead of construction `[...array].reverse()` offering a more modern and simpler solution
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
closing for same reason as #2575 toReversed is a baseline 2023 feature and vite's default target is baseline-widely-available. If you use toReversed it won't work in some browsers without a polyfill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
This is not a problem but a stylistic suggestion.
The example currently uses
[...array].reverse(), which can be simplified using a more modern and concise syntax.Proposed Solution
Suggest using the simpler:
array.toReversed()This achieves the same result reversing the array without mutating the original, but in a cleaner and more modern way.
Additional Information
array.toReversed() was introduced in ECMAScript 2023