Skip to content

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Sep 5, 2025

resolve #2823

Copy link

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: c943abf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@FloEdelmann FloEdelmann requested a review from Copilot September 5, 2025 13:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the vue/no-mutating-props and vue/no-side-effects-in-computed-properties rules to detect mutations caused by Object.assign() when the target object (first argument) is a prop or reactive data.

Key changes:

  • Added utility function to detect Object.assign calls with specific target nodes
  • Enhanced mutation detection logic to identify Object.assign as a mutation operation
  • Added comprehensive test coverage for both valid and invalid Object.assign usage patterns

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
lib/utils/index.js Added isObjectAssignCall utility function and integrated Object.assign detection into mutation analysis
tests/lib/rules/no-mutating-props.js Added test cases for Object.assign prop mutation detection
tests/lib/rules/no-side-effects-in-computed-properties.js Added test cases for Object.assign side effect detection in computed properties
.changeset/hot-beers-help.md Added changelog entry documenting the enhancement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue/no-mutating-props should warn on Object.assign with prop as first argument
2 participants