Skip to content

Conversation

2nofa11
Copy link
Contributor

@2nofa11 2nofa11 commented Sep 6, 2025

Update tests/integrations/eslint-plugin-import/package.json to use ESLint ^9 (or ^8) and eslint-plugin-import ^2.31.0, matching the plugin’s peerDependencies (^8 || ^9).
Test-only; no user-facing changes.

closed #2930
Linked to: #2916

Copy link

changeset-bot bot commented Sep 6, 2025

⚠️ No Changeset found

Latest commit: 124c58f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@2nofa11 2nofa11 force-pushed the test/align-import-integration-eslint9 branch from e090489 to dd29176 Compare September 6, 2025 08:32
@2nofa11 2nofa11 marked this pull request as ready for review September 6, 2025 08:46
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 🙂

@FloEdelmann FloEdelmann requested a review from Copilot September 18, 2025 12:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the ESLint plugin import integration test to use ESLint version 9 and migrates from the legacy .eslintrc.json configuration format to the new flat config format (eslint.config.mjs).

  • Upgrades ESLint from ^7.0.0 to ^9.0.0 and eslint-plugin-import from ~2.23.4 to ^2.31.0
  • Migrates from legacy .eslintrc.json to flat config eslint.config.mjs format
  • Updates test execution to use the new configuration file

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/integrations/eslint-plugin-import/package.json Updates ESLint and eslint-plugin-import versions
tests/integrations/eslint-plugin-import/eslint.config.mjs Adds new flat config format configuration
tests/integrations/eslint-plugin-import/.eslintrc.json Removes legacy configuration file
tests/integrations/eslint-plugin-import.js Updates test to use new config file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@FloEdelmann FloEdelmann merged commit 3e122e5 into vuejs:master Sep 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align import integration fixture with supported ESLint versions
2 participants