Skip to content

feat(compiler): add warning when directives other than v-for and v-if used on template tag #7857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

feat(compiler): add warning when directives other than v-for and v-if used on template tag #7857

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8824c9
feat(compiler): add warning when v-show used on template tag
Mar 19, 2018
71714a3
feat(compiler): add warning for all not allowed directives
Mar 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/compiler/codegen/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,13 @@ export function genElement (el: ASTElement, state: CodegenState): string {
} else if (el.if && !el.ifProcessed) {
return genIf(el, state)
} else if (el.tag === 'template' && !el.slotTarget) {
if (process.env.NODE_ENV !== 'production' &&
el.directives && el.directives.length > 0 &&
el.directives.find(directive => directive.name === 'show')) {
state.warn('v-show cannot be used on a template tag. ' +
'See https://vuejs.org/v2/guide/conditional.html#v-show for more info.')
}

return genChildren(el, state) || 'void 0'
} else if (el.tag === 'slot') {
return genSlot(el, state)
Expand Down