T5811: Move DHCP gateway address lookup to FRR #4648
Conversation
|
👍 |
First https://github.com/hedrok/vyos-build/pull/new/T5811-add-frr-dhcp-gateway must be merged, as this change requires new FRR route type: ip route 10.1.2.0/24 dhcp-gateway eth0 That is added in the PR to vyos-build. This commit mitigates various problems that arise from changing of DHCP gateway for an interface and no updates of routes accordingly.
hedrok
force-pushed
the
T5811-static-dhcp-routes-reboot
branch
from
b8dce51 to
0cf21cf
Compare
|
CI integration ❌ failed! Details
|
There was a problem hiding this comment.
Pull Request Overview
This PR moves DHCP gateway address lookup responsibility from the VyOS configuration layer to FRR (Free Range Routing), fixing issues with routes via DHCP gateway not being properly maintained when DHCP state changes.
- Replaces explicit DHCP router IP lookup with FRR's
dhcp-gatewaykeyword - Adds a DHCP client exit hook to notify FRR when DHCP events occur
- Removes template logic that resolved DHCP gateway IPs at configuration time
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/etc/dhcp/dhclient-exit-hooks.d/04-frr-dhcp-gateway-hook | Adds DHCP client hook to notify FRR of DHCP state changes |
| data/templates/frr/staticd.frr.j2 | Replaces hardcoded DHCP gateway IPs with FRR's dhcp-gateway keyword |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # Copyright (C) 2025 VyOS Inc. | ||
| # Kyrylo Yatsenko | ||
|
|
||
| # Try to inform FRR of any events that can change ip or DHCP state |
There was a problem hiding this comment.
The comment contains a grammatical error. 'ip' should be capitalized as 'IP' when referring to Internet Protocol.
| # Try to inform FRR of any events that can change ip or DHCP state | |
| # Try to inform FRR of any events that can change IP or DHCP state |
|
I see merging into FRR upstream any dhcpgw feature quite improbable, starting developing VyOS-side solution, so close this PR. |
1 participant
Change summary
Fixes various problems with routes via dhcp gateway by moving responsibility to FRR.
First PR to vyos-build must be merged: vyos/vyos-build#1004
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos-build#1004
How to test / Smoketest result
Create topology of VyOS DHCP client and VyOS DHCP server.
Add static route for client:
Stop link between client-server, reboot client. Wait a little. Start link between client-server.
Before fix no route is added. After fix route is added.
Checklist: