-
Notifications
You must be signed in to change notification settings - Fork 392
T7965: reapply the QoS policy when the interface reconnect #4816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
opswill
wants to merge
1
commit into
vyos:current
Choose a base branch
from
opswill:current
base: current
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| #!/usr/bin/env python3 | ||
|
|
||
| # Dynamic interfaces may lose QoS config on reconnect. | ||
| # This script reapplies the QoS policy when the interface comes up. | ||
|
|
||
| from sys import argv | ||
| from sys import exit | ||
| from vyos.utils.process import call | ||
| from vyos.configquery import ConfigTreeQuery | ||
|
|
||
| # When the ppp link comes up, this script is called with the following | ||
| # parameters | ||
| # $1 the interface name used by pppd (e.g., pppoe0, l2tpc0, sstpc0) | ||
| # $2 the tty device name | ||
| # $3 the tty device speed | ||
| # $4 the local IP address for the interface | ||
| # $5 the remote IP address | ||
| # $6 the parameter specified by the 'ipparam' option to pppd | ||
|
|
||
| if len(argv) < 7: | ||
| exit(1) | ||
|
|
||
| interface = argv[6] | ||
|
|
||
| conf = ConfigTreeQuery() | ||
|
|
||
| try: | ||
| # Check if QoS is configured for the interface | ||
| qos_path = ['qos', 'interface', interface] | ||
| if conf.exists(qos_path): | ||
| call('/usr/libexec/vyos/conf_mode/qos.py') | ||
| except Exception: | ||
| exit(1) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looping in @jestabro - Do you think this is the best way to call the conf script from here?