Skip to content

Conversation

omnom62
Copy link
Contributor

@omnom62 omnom62 commented Aug 19, 2025

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7621

Related PR(s)

Component(s) name

vyos_firewall_global

Proposed changes

How to test

Test results

  • Sanity tests passed
  • Unit tests passed

Tested against VyOS versions:

  • 1.3.8
  • 1.4-rolling-202201010100
  • 1.5-stream-2025-Q1

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the ansible sanity and unit tests
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added unit tests to cover my changes
  • I have added a file to changelogs/fragments to describe the changes

@omnom62 omnom62 marked this pull request as ready for review August 20, 2025 10:33
@omnom62 omnom62 requested a review from a team as a code owner August 20, 2025 10:33
@omnom62 omnom62 requested a review from gaige August 21, 2025 22:26
@omnom62 omnom62 requested a review from gaige August 22, 2025 23:50
Copy link
Contributor

@gaige gaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omnom62 I'm comfortable with your current code. I'm adding the regex options here if you want to look at them. Honestly, they're harder to read than your straight-up checks and there may not be a real benefit to them unless we see a lot of variability.

You might want to make a note on which version has the missing space and the missing quotes, just so we know when we can remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants