-
Notifications
You must be signed in to change notification settings - Fork 68
T7621 vyos_firewall_global features #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
plugins/module_utils/network/vyos/config/firewall_global/firewall_global.py
Outdated
Show resolved
Hide resolved
tests/integration/targets/vyos_firewall_global/tests/cli/replaced.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omnom62 I'm comfortable with your current code. I'm adding the regex options here if you want to look at them. Honestly, they're harder to read than your straight-up checks and there may not be a real benefit to them unless we see a lot of variability.
You might want to make a note on which version has the missing space and the missing quotes, just so we know when we can remove them.
Change Summary
Types of changes
Related Task(s)
https://vyos.dev/T7621
Related PR(s)
Component(s) name
vyos_firewall_global
Proposed changes
How to test
Test results
Tested against VyOS versions:
Checklist:
changelogs/fragments
to describe the changes