refactor[venom]: strengthen an assumption in venom lowering #4715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit strengthens an assumption in venom_to_assembly. due to SSA form, the arguments to phi must be in the predecessor blocks. this means that the def does not reach any use from both branches, except in the case that the use is a phi.
phi single use and fix of the simplify cfg pass
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4715 +/- ##
==========================================
+ Coverage 93.00% 93.04% +0.03%
==========================================
Files 131 131
Lines 19095 19167 +72
Branches 3324 3329 +5
==========================================
+ Hits 17760 17834 +74
Misses 898 898
+ Partials 437 435 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reduced the regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit strengthens an assumption in venom_to_assembly. due to SSA form, the arguments to phi must be in the predecessor blocks. this means that the def does not reach any use from both branches, except in the case that the use is a phi.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture