refactor[venom]: refactor assembler and *more* #4717
Conversation
explicit Label/PUSHLABEL instructions.
harkal
changed the title
harkal
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| class DATA_ITEM: | ||
| data: bytes | Label | ||
|
|
||
| def __repr__(self) -> str: |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
|
|
||
|
|
||
| # a string (assembly instruction) but with additional metadata from the source code | ||
| class TaggedInstruction(str): |
Check warning
Code scanning / CodeQL
`__eq__` not overridden when adding attributes Warning
| """Generate a unique label name for an unresolved constant.""" | ||
| global _const_label_counter | ||
| label = f"__const_{_const_label_counter}" | ||
| _const_label_counter += 1 |
Check notice
Code scanning / CodeQL
Unused global variable Note
| from vyper.evm.address_space import MEMORY, STORAGE, TRANSIENT, AddrSpace | ||
| from vyper.exceptions import CompilerPanic | ||
| from vyper.venom.basicblock import IRLiteral, IROperand, IRVariable | ||
| from vyper.venom.basicblock import ConstRef, IRLabel, IRLiteral, IROperand, IRVariable |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| from vyper.evm.address_space import MEMORY, STORAGE, TRANSIENT, AddrSpace | ||
| from vyper.exceptions import CompilerPanic | ||
| from vyper.venom.basicblock import IRLiteral, IROperand, IRVariable | ||
| from vyper.venom.basicblock import ConstRef, IRLabel, IRLiteral, IROperand, IRVariable |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| from vyper.evm.address_space import MEMORY, STORAGE, TRANSIENT, AddrSpace | ||
| from vyper.exceptions import CompilerPanic | ||
| from vyper.venom.basicblock import IRLiteral, IROperand, IRVariable | ||
| from vyper.venom.basicblock import ConstRef, IRLabel, IRLiteral, IROperand, IRVariable |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| from vyper.evm.address_space import MEMORY, STORAGE, TRANSIENT, AddrSpace | ||
| from vyper.exceptions import CompilerPanic | ||
| from vyper.venom.basicblock import IRLiteral, IROperand, IRVariable | ||
| from vyper.venom.basicblock import ConstRef, IRLabel, IRLiteral, IROperand, IRVariable |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| from vyper.evm.address_space import MEMORY, STORAGE, TRANSIENT, AddrSpace | ||
| from vyper.exceptions import CompilerPanic | ||
| from vyper.venom.basicblock import IRLiteral, IROperand, IRVariable | ||
| from vyper.venom.basicblock import ConstRef, IRLabel, IRLiteral, IROperand, IRVariable |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
empty db constructor jump error test add PC_RESET instruction pc reset stuff cleanup basicblock parser tag handling enhance unresolved constant check in VenomCompiler add CFG normalization check refactor stack handling refactor VenomCompiler to differentiate between constant references and labels in assembly generation import PC_RESET handle PC_RESET in resolve_symbols runtime actual position handling fix symbol map updates implement _resolve_push_ofst_value function for PUSH_OFST offset resolution
| # Process global label expressions that were stored separately | ||
| for name, expr in list(self.ctx.const_expressions.items()): | ||
| if name.startswith("_global_label_"): | ||
| label_name = name[len("_global_label_") :] |
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture