feat[venom]: venom command line parameters #4757
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| AssignElimination(ac, fn).run_pass() | ||
| CSE(ac, fn).run_pass() | ||
| def _run_passes(fn: IRFunction, flags: VenomOptimizationFlags, ac: IRAnalysesCache) -> None: | ||
| passes = OPTIMIZATION_PASSES.get(flags.level, OPTIMIZATION_PASSES[OptimizationLevel.O2]) |
There was a problem hiding this comment.
probably better to fail with a key lookup error since it indicates a mistake in the optimization passes dict (or how we have constructed flags.level)
| if field.name == "venom_flags": | ||
| # Skip venom_flags - we'll handle it after optimization level is merged | ||
| continue | ||
| else: |
There was a problem hiding this comment.
can dedent this - no need for else since the if branch hits continue
Comment on lines
+259
to
+260
| if args.no_inlining: | ||
| settings.venom_flags.disable_inlining = True |
There was a problem hiding this comment.
can we do it like this?
Suggested change
| if args.no_inlining: | |
| settings.venom_flags.disable_inlining = True | |
| settings.venom_flags.disable_inlining = args.no_inlining |
|
|
||
| # Disable flags - default False means optimization is enabled | ||
| # These are used to override the defaults for the optimization level | ||
| disable_inlining: bool = False |
There was a problem hiding this comment.
not sure there is anything to be done atm but i am concerned about long term drift between these fields and the relevant code in vyper_compile.py and vyper_json.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture