Skip to content

Infrastructure: Temp fix to regression test - Fix toolbar_toolbar.js by resetting menu button state #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

Infrastructure: Temp fix to regression test - Fix toolbar_toolbar.js by resetting menu button state #3354

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eb8d97
Reset state of menuButton if needed
howard-e Aug 18, 2025
614ed43
Leave comment on workaround to be resolved
howard-e Aug 19, 2025
3843894
Leave comment on workaround to be resolved
howard-e Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/tests/toolbar_toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ ariaTest(
let menu = await t.context.session.findElement(By.css(ex.menuSelector));

for (let i = 0; i < menuItems.length; i++) {
// Reset expanded state if necessary
// Note: This is a workaround. In the test environment, the menu button's
// aria-expanded state isn't being set back to false on a menu option
// click which requires this workaround.
// Issue tracked at https://github.com/w3c/aria-practices/issues/3331
// TODO: Remove once fixed
if ((await menuButton.getAttribute('aria-expanded')) === 'true') {
await menuButton.click();
}
await menuButton.click();
await t.context.session.wait(
async function () {
Expand Down