Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Once this PR has been reviewed and has consensus from the working group, tests s
* WebKit:
* Gecko:
* Blink:
* [ ] ACT review?
* [ ] Does this need AT implementations?
* [ ] Related APG Issue/PR:
* [ ] MDN Issue/PR:
13 changes: 10 additions & 3 deletions documentation/process.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,19 @@ A "normative" change is change to the specification that is not editorial, that
- Any working group member can add themselves as a reviewer.
- Any one from the general public is allowed to review PRs in order to inform the ARIA WG of approval or concerns.
3. **Tests:** If the change is testable, tests should be add to the validators directory or WPT repo before merging, or, if the PR owner does not have the expertise to write tests, issues should be file in the ARIA repository as a follow up. See [Aria Test Overview](tests.md).
4. **APG:** If the change requires a change to the [APG](https://github.com/w3c/aria-practices), an issue on the APG should be made describing the change.
5. **Implementation:** If the change requires implementation changes, issues should be opened on the browser after the PR has been approved.
- At least one implementation is required for merge. Implementation or implementation commitment from two browsers is required for merge.
4. **APG:** If the PR will required changes to the [APG](https://github.com/w3c/aria-practices), an issue on the APG should be made describing the change.
5. **ACT Review:** If the PR will require [ACT rules](https://www.w3.org/WAI/standards-guidelines/act/rules/) changes, then the label "needs ACT review" must be added. This will trigger the process of triage and potentially review by the [ACT Task Force](https://www.w3.org/WAI/about/groups/task-forces/conformance-testing/). When the PR has been reviewed and concerns resolved, the ACT Task Force will mark the PR as approved by checking the box in the PR tracking list in the description of the PR. The label may be added at different times:
- If the change introduces an "authors must", or if the editors think the change will have a significant effect on authors, the label should be added the same time reviewers are requested.
- If the change minimally effects authors, the label can be added when issues are opened on browsers.
6. **Implementation:** If the change requires implementation changes, issues should be opened on the browser after the PR has been approved and tests have been authored.
- At least one implementation is required for merge. Implementation or implementation commitment from two browsers is required for merge.

Note: The fact that a PR requires implementation to merge is new as of 2022. We understand this will cause the life of a PR to be long -- and that the original champion of the PR might need to hand off work to another ARIA WG member while the PR waits for implementations.

#### After merge

1. If the change introduces, removes or affects existing "Author MUST" statements, open issues on validators.

#### Stages of a normative change

##### Stage one: `Waiting for Review`
Expand Down