-
Notifications
You must be signed in to change notification settings - Fork 137
Add interestfor attribute related mappings #2617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Uber-caveat: I cargo-culted much of what I added here, e.g. the sections with "MSAA" and "UIA". Please tell me what I did wrong, and give me a hint at how to fix it, and I'll do my best. |
41fc5e0 to
526cd4f
Compare
html-aam/index.html
Outdated
| <ul> | ||
| <li><p>If the popover is displayed: <a class="core-mapping" href="#ariaExpandedTrue">`aria-expanded=true`</a></p></li> | ||
| <li><p>If the popover is hidden: <a class="core-mapping" href="#ariaExpandedFalse">`aria-expanded=false`</a></p></li> | ||
| <li><p>Set a <a>minimum role</a> of <a class="core-mapping" href="#role-map-tooltip">`tooltip`</a> on the target popover</p></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A link to minimum role may be helpful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I was using <a>minimum role</a> for that link, perhaps it doesn't work? Looking through the source, there is one definition of "minimum role", five references with no link (minimum role), one with just an <a> (<a>minimum role</a>), and four with <a href="termref">minimum role</a>. I've just changed to that last incantation - hopefully that fixes the link?
This adds the mapping for the `interestfor` attribute. See [the explainer](https://open-ui.org/components/interest-invokers.explainer/) for the overall API description and use cases. Update link Hopefully fix link
526cd4f to
722dc53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving after further review/feedback. Thank you for providing additional information @mfreed7!
Great, thanks! I appreciate the review. There's one open question about the |
This adds the mapping for the
interestforattribute.See the explainer for the overall API description and use cases.
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.