Skip to content

Conversation

@mfreed7
Copy link

@mfreed7 mfreed7 commented Sep 2, 2025

This adds the mapping for the interestfor attribute.

See the explainer for the overall API description and use cases.

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

@netlify
Copy link

netlify bot commented Sep 2, 2025

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit bac5f87
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/68b74e8c60c4720008b7056e
😎 Deploy Preview https://deploy-preview-2617--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 2, 2025

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 722dc53
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/68d1bfad30c7c2000854e258
😎 Deploy Preview https://deploy-preview-2617--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mfreed7
Copy link
Author

mfreed7 commented Sep 2, 2025

Uber-caveat: I cargo-culted much of what I added here, e.g. the sections with "MSAA" and "UIA". Please tell me what I did wrong, and give me a hint at how to fix it, and I'll do my best.

<ul>
<li><p>If the popover is displayed: <a class="core-mapping" href="#ariaExpandedTrue">`aria-expanded=true`</a></p></li>
<li><p>If the popover is hidden: <a class="core-mapping" href="#ariaExpandedFalse">`aria-expanded=false`</a></p></li>
<li><p>Set a <a>minimum role</a> of <a class="core-mapping" href="#role-map-tooltip">`tooltip`</a> on the target popover</p></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to minimum role may be helpful here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I was using <a>minimum role</a> for that link, perhaps it doesn't work? Looking through the source, there is one definition of "minimum role", five references with no link (minimum role), one with just an <a> (<a>minimum role</a>), and four with <a href="termref">minimum role</a>. I've just changed to that last incantation - hopefully that fixes the link?

This adds the mapping for the `interestfor` attribute.

See [the explainer](https://open-ui.org/components/interest-invokers.explainer/)
for the overall API description and use cases.

Update link

Hopefully fix link
Copy link

@front-endian front-endian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after further review/feedback. Thank you for providing additional information @mfreed7!

@mfreed7
Copy link
Author

mfreed7 commented Oct 10, 2025

Approving after further review/feedback. Thank you for providing additional information @mfreed7!

Great, thanks! I appreciate the review.

There's one open question about the <a>minimum role</a> link - I'm not sure if anything needs to be fixed there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants