Editorial: Change failures to warnings for RFC2119 keywords #2651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pkra
approved these changes
Oct 14, 2025
|
Looks ok to me but I don't know enough about github actions to say this will work as desired. |
|
I have tried this at https://github.com/daniel-montalvo/aria/actions/runs/18534545894/job/52825998393?pr=9 It still throws the error from the github action we are using but also adds the adhoc warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have this check that simply fails if it finds RFC2119 keywords. I think that's too hard for this check, especially if we plan to move to a situation where we do want to actively have failing checks prevent merges.
I think the best for us here is for this to just throw a warning to make sure the keyword uses are intended.