Skip to content

[css-view-transitions-2] Resolve finished promise at own task when animations are done #12957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −4
Open

[css-view-transitions-2] Resolve finished promise at own task when animations are done #12957

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02fbadb
[css-view-transitions-2] Resolve finished promise at own task when an…
noamr Oct 16, 2025
5316934
Add phase
noamr Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions css-view-transitions-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1788,6 +1788,7 @@ Issue: Is this updated by a <code>rootEl.startViewTransition()</code> call, too?
1. "`pending-capture`".
1. "`update-callback-called`".
1. "`animating`".
1. "`pending-done`".
1. "`done`".

Note: For the most part, a developer using this API does not need to worry about the different phases, since they progress automatically.
Expand Down Expand Up @@ -3133,13 +3134,17 @@ To <dfn>adjust nested view transition group transform</dfn> given a |transform|

- |document|'s [=pending animation event queue=] has any events associated with |animation|.

1. If |hasActiveAnimations| is false:
1. If |hasActiveAnimations| is false and transition|'s [=ViewTransition/phase=] to "`animating`",

1. Set |transition|'s [=ViewTransition/phase=] to "`done`".
1. Set |transition|'s [=ViewTransition/phase=] to "`pending-done`".

1. [=Clear view transition=] |transition|.
1. [=Queue a global task=] on the [=DOM manipulation task source=],
given |transition|'s [=relevant global object=],
to perform the following step:
If |transition|'s [=ViewTransition/phase=] is "`pending-done`", then:
1. [=Resolve=] |transition|'s [=ViewTransition/finished promise=].

1. [=Resolve=] |transition|'s [=ViewTransition/finished promise=].
1. [=Clear view transition|clear=] |transition|.

1. Return.

Expand Down