[css-ui-4][editorial] Let outline-color refer to border-top-color values
#12993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loirooriol
approved these changes
Oct 21, 2025
SebastianZ
force-pushed
the
css-ui-4-outline-color-values
branch
from
938f918 to
e0f27e4
Compare
SebastianZ
force-pushed
the
css-ui-4-outline-color-values
branch
from
e0f27e4 to
dbed5ac
Compare
|
Given @Loirooriol's approval and that a71367a seems to have introduced that issue by mistake, I am going to merge this. @frivoal @tabatkins @fantasai Please let me know if there are any issues! Sebastian |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of
outline-colorrefers to<'border-color'>while its syntax definition explicitly contains<color> | <image-1D>.This has two issues:
border-coloris a shorthand that takes one to four values, which is not what was intended foroutline-colorSo this PR changes them to both refer to
<'border-top-color'>, which only takes one value and is also referenced in other related places.Sebastian