Skip to content

Conversation

@joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Jun 18, 2024

Issue #521

This clarifies current reality in implementation, and may be enough to close the issue on that basis. But I plan to propose one small behavioral change after this clarification, which there may or may not be consensus on.


Preview | Diff

Comment on lines +2548 to +2549
levels specified in the configuration of the {{MediaKeySystemAccess}} object used
to create the {{MediaKeys}} object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
levels specified in the configuration of the {{MediaKeySystemAccess}} object used
to create the {{MediaKeys}} object.
levels specified in the configuration of the {{MediaKeySystemAccess}} dictionary used
to create the {{MediaKeys}} instance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "MediaKeySystemAccess object" is right here - it's an interface, whereas MediaKeySystemConfiguration is a dictionary.

Comment on lines +2558 to +2559
Applications are recommended to specify the robustness level(s) they require,
if any, to avoid unexpected client incompatibilities.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Applications are recommended to specify the robustness level(s) they require,
if any, to avoid unexpected client incompatibilities.
To avoid unexpected interoperability issues, developers are encouraged to provide the robustness level(s)
(if any).

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of wording suggestions... I'm not very familiar with how EME works, so would need someone else to check the technical details.

Copy link
Member

@chrisn chrisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to respond. I left one comment for consideration.

I notice there's a few other Notes that contain normative statements that we'll need to review too.

highest robustness level in the configuration even if a higher robustness level
is available. If only the empty string is specified, implementations MAY be
configured to use the lowest robustness level the implementation supports.
Exact configuration of the [=CDM=] is implementation-specific.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to remove the note entirely, and keep the "implementations MAY configure" language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants