Skip to content

Try redesigning the style of authoring-html #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: gh-pages
Choose a base branch
from

Conversation

xfq
Copy link
Member

@xfq xfq commented May 23, 2025

Try redesigning the style of Internationalization techniques: Authoring web pages. Let me know what you think!

Current page: https://www.w3.org/International/techniques/authoring-html

Preview

Copy link

netlify bot commented May 23, 2025

Deploy Preview for i18n-drafts ready!

Name Link
🔨 Latest commit 6e5ecd7
🔍 Latest deploy log https://app.netlify.com/projects/i18n-drafts/deploys/68667ae3d2efad00083e3c78
😎 Deploy Preview https://deploy-preview-665--i18n-drafts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@r12a
Copy link
Contributor

r12a commented May 23, 2025

It's certainly colourful. There are however a number of things i think we need to consider changing. Perhaps a topic for our next 1:1. Note also the comments on a previous commit about line lengths, that were shortened by the move to a new base style sheet.

Also, note that the headings overlap the expanded TOC - another result i think of the style sheet change.

@xfq
Copy link
Member Author

xfq commented May 30, 2025

the headings overlap the expanded TOC

I fixed a few issues, but not this one. I couldn't find the source of this issue, and I didn't modify any z-index related style...

@xfq
Copy link
Member Author

xfq commented Jun 3, 2025

the headings overlap the expanded TOC

I fixed a few issues, but not this one. I couldn't find the source of this issue, and I didn't modify any z-index related style...

I just found that even if I deleted all the code I added, the problem still occurs:

Screenshot 2025-06-03 at 15 08 57

I will take a closer look to find out what caused it.

@xfq
Copy link
Member Author

xfq commented Jun 3, 2025

Should be fixed now. Please take a look.

@xfq xfq requested a review from r12a June 3, 2025 07:21
@xfq
Copy link
Member Author

xfq commented Jun 6, 2025

@r12a After I discussed with you, I further modified the style, please take a look.

@r12a
Copy link
Contributor

r12a commented Jun 6, 2025

There's still a problem with overlapping content when the browser window is narrow:

Screenshot 2025-06-06 at 06 04 39

I think the width needs to be applied to the column, perhaps, rather than the menu? (Btw, fwiw, i thought 15rem was probably wide enough when i did some testing — that also helps for narrow windows.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants