-
Notifications
You must be signed in to change notification settings - Fork 21
Added caBX chunk for Content Credentials #542
#544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Awaiting @lrosenthol 's input.
|
Should the document be repeating C2PA's security claims ("secure, tamper-evident ...") as-is? I've seen others dispute whether the chunk meets its security goals. For instance, this author has been quite vocal against it. |
|
Thanks for the link, those should certainly be added to the Security Considerations. Dropping an entire |
|
This analysis seems fairly worrying; in particular, a bunch of data was removed from a PNG image, other data added, and it still validates as unaltered. |
|
I'll review the PR in sec, but let me comment on those specific blogs... The author of those pages has a long history of "intermixing" implementations with specifications. All of the issues in those blogs were in specific implementations that long been fixed! They also all pre-date the C2PA's new Conformance Program (https://c2pa.org/conformance/) and refer to older versions of our specification. We can certainly point to the security sections of the C2PA specification itself if you wish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor editorials
| 63 61 42 58 | ||
| </pre> | ||
|
|
||
| <p>The <span class="chunk">caBX</span> chunk contains content credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <p>The <span class="chunk">caBX</span> chunk contains content credentials | |
| <p>The <span class="chunk">caBX</span> chunk contains Content Credentials |
|
|
||
| <p>The <span class="chunk">caBX</span> chunk contains content credentials | ||
| (provenance, and edit history) metadata | ||
| in a secure, tamper-evident (cryptographically verifiable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| in a secure, tamper-evident (cryptographically verifiable) | |
| in a tamper-evident (cryptographically verifiable) |
| in a secure, tamper-evident (cryptographically verifiable) | ||
| and standardized way | ||
| to enable publishers and consumers | ||
| to determine the authenticity of media. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| to determine the authenticity of media. | |
| to determine the authenticity of media. | |
| It can also be used to declare whether a given image | |
| was created or edited by Generative AI or a human | |
| or a combination of same. |
| </p> | ||
|
|
||
| <p>For embedding into PNG, | ||
| <a href="https://spec.c2pa.org/specifications/specifications/2.2/specs/C2PA_Specification.html#_embedding_manifests_into_png">section A.3.2. of Content Credentials</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <a href="https://spec.c2pa.org/specifications/specifications/2.2/specs/C2PA_Specification.html#_embedding_manifests_into_png">section A.3.2. of Content Credentials</a> | |
| <a href="https://spec.c2pa.org/specifications/specifications/2.2/specs/C2PA_Specification.html#_embedding_manifests_into_png">section A.3.2. of the Content Credentials specification</a> |
This intentionally brief chunk description does three things:
I updated the chunk ordering table to add
caBX, requiring that it be beforeIDAT(CC suggests but does not require before IDAT) and also to disallow multiplecaBX. @lrosenthol are those correct?I have not yet updated the chunk ordering diagrams, pending review of this PR.