Skip to content

Suggestions from January review on §1.4 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 17, 2025
Merged

Conversation

pchampin
Copy link
Contributor

@pchampin pchampin commented Apr 23, 2025

@pchampin pchampin added the spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial label Apr 23, 2025
@pchampin pchampin requested review from gkellogg, afs and hartig April 23, 2025 23:46
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally like this, but the bit on prefixed IRIs can use some improvement

@pfps
Copy link
Contributor

pfps commented May 1, 2025

Isn't this just editorial.

pchampin and others added 6 commits July 4, 2025 16:16
Bob DuCharme's 2nd comment
https://www.w3.org/mid/[email protected]

not exactly Bob's suggestion,
but I think it addresses the core of the issue.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
re-reading this, I realized it could be surprising:
the predicate position of a triple is a "context where IRIs are expected",
and so this text could read as "don't use abbreviated forms in the predicate position",
which is of course not how it was intended.
@pchampin pchampin force-pushed the 2025-01-reviews-s1.4 branch from 5f5790b to 9ee0284 Compare July 4, 2025 14:16
... with some slight adaptations

*: #194 (comment)
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@pchampin pchampin requested a review from TallTed July 8, 2025 10:45
pchampin and others added 2 commits July 8, 2025 19:13
Co-authored-by: Andy Seaborne <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@pchampin pchampin merged commit d88fb40 into main Jul 17, 2025
2 checks passed
pchampin added a commit that referenced this pull request Jul 17, 2025
... with some slight adaptations

*: #194 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants