2025 iherman review #249
Open
2025 iherman review #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
people could read "this definition" in the note as referring to the definition just above the note, i.e. the definition of "term equality". This is inaccurate and confusing. Moving the note closer to the definition of "triple" aims to clarify that.
afs
approved these changes
Oct 16, 2025
niklasl
approved these changes
Oct 16, 2025
hartig
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing two comments made by @iherman in a private conversation.
Besides the missing colon, the main change is to move the note about "triples can not form cycles" closer to the definition of cycles.
Currently people could read the word "this definition" in the note as referring to the definition just above the note, i.e. the definition of "term equality". This is inaccurate and confusing. Moving the note closer to the definition of "triple" aims to clarify that.
Preview | Diff