Skip to content

Conversation

jyasskin
Copy link
Member

@jyasskin jyasskin commented Jan 10, 2025

This is ready for review, @pes10k and @simoneonofri.


Preview | Diff

simoneonofri added a commit that referenced this pull request Feb 4, 2025
This should solve this #185
@jyasskin jyasskin marked this pull request as ready for review February 5, 2025 16:54
Copy link
Contributor

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only suggestion, which I think appropriate for including as part of this PR removing the TAG from the groups responsible, is to somewhere (Acknowledgments? up to editor discretion) note that this document was originally created by the TAG (or equivalent wording). Origins matter.

@jyasskin
Copy link
Member Author

jyasskin commented Apr 22, 2025

I've taken @tantek's suggestion in 1b5ecab, with the modification that the TAG didn't originally create the document.

We'll need one of the editors to actually merge.

Copy link
Contributor

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements @jyasskin certainly along the intent of my suggestion. Appreciated. Added a minor suggested change highlighting the significance of TAG's past role. Up to editor discretion.

@pes10k
Copy link
Contributor

pes10k commented Apr 24, 2025

fwiw, i think this looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants