Technique ARIA14: Replacing “invisible label” with “accessible name” #4482
+136
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry that this will make the actual PR more difficult to read, but it’s necessary to be able to efficiently make changes for me.
Trying to be clear that aria-label sets the accessible name, also clarified some text. This technique could probably do with more examples of screen reader and voice input interactions, I’m not sure if readers understand what the impact really is and why it is important.
|
yatil marked as non substantive for IPR from ash-nazg. |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hidde
reviewed
Jul 3, 2025
patrickhlauke
requested changes
Jul 3, 2025
There was a problem hiding this comment.
once the working example is modified as well, this looks good to me
Preview: https://deploy-preview-4482--wcag2.netlify.app/techniques/aria/aria14
Working example is now using an html dialog and also some more styling, just to be fancy. I also synced the example back to the technique.
#Conflicts: # techniques/aria/ARIA14.html
hidde
reviewed
Jul 4, 2025
Co-authored-by: Hidde de Vries <[email protected]>
patrickhlauke
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to be clear that aria-label sets the accessible name, also clarified some text. This technique could probably do with more examples of screen reader and voice input interactions, I’m not sure if readers understand what the impact really is and why it is important.
I also modernised the language from “lightbox” to dialog, but I left the example mostly as is for now. It would be good to update it to a proper
<dialog>example.My apologies for automatically re-indenting the file, but it is so difficult to work with these files otherwise.