Skip to content

Remove ineffectual code #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove ineffectual code #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/runtime/handler/vertical_ui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,6 @@ func (handler *VerticalUI) doRegister(task *runtime.Task) {

hasParentCmd := task.Config.CmdString != ""
hasHeader := len(task.Children) > 0
numTasks := len(task.Children)
if hasParentCmd {
numTasks++
}

// we should overwrite the footer of the last frame when creating a new frame (kinda hacky... todo: replace this)
isFirst := handler.frame == nil
Expand Down
3 changes: 1 addition & 2 deletions pkg/runtime/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ func (task *Task) Execute(eventChan chan TaskEvent, waiter *sync.WaitGroup, envi
}

returnCode := 0
returnCodeMsg := "unknown"
if err := task.Command.Cmd.Wait(); err != nil {
if exiterr, ok := err.(*exec.ExitError); ok {
// The program has exited with an Exit code != 0
Expand All @@ -248,7 +247,7 @@ func (task *Task) Execute(eventChan chan TaskEvent, waiter *sync.WaitGroup, envi
}
} else {
returnCode = -1
returnCodeMsg = "Failed to run: " + err.Error()
returnCodeMsg := "Failed to run: " + err.Error()
eventChan <- TaskEvent{Task: task, Status: StatusError, Stderr: returnCodeMsg, ReturnCode: returnCode}
task.Command.errorBuffer.WriteString(returnCodeMsg + "\n")
}
Expand Down