Replace System.out/err.println with logging in analysis and test code #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the codebase to replace
System.out.println()
andSystem.err.println()
statements with proper logging in non-CLI analysis, processing, and test code, while preserving appropriate print statements in CLI-related functionality.Changes Made
Refactored 37 instances across key analysis components and test files:
PythonCAstToIRTranslator
,PythonTurtleSKLearnClassifierAnalysis
,PythonTurtlePandasMergeAnalysis
, andPythonSSAPropagationCallGraphBuilder
TensorType
and error logging inCloudFunction
PythonParser
classesPytestLoader
andPython2Loader
PytestAnalysisEngine
ParquetPythonReader
TestClasses.java
,TestCalls.java
,TestSource.java
, andTestPythonMLCallGraphShape.java
Established consistent logging patterns:
private static final Logger LOGGER = Logger.getLogger(ClassName.class.getName());
LOGGER.fine()
for debug information,LOGGER.info()
for status messages,LOGGER.severe()
for errorsjava.util.logging
Preserved CLI-appropriate usage:
Ariadne.java
main method error handling and user messagesDiagnosticsFormatter.java
print methods for user-facing outputshowMessage()
methods for user communicationExample
Before:
After:
The changes improve code maintainability by centralizing logging configuration and allowing proper log level control throughout both production and test code, while maintaining all existing CLI functionality for end users.
Fixes #331.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.