Bring Magento template up-to-date #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update services for Magento 2.4.6, including using MariaDB 10.6 and OpenSearch 2.5 - Remove installation of hirak/prestissimo as we're now using Composer 2 - Add composer auth prompting during bootstrap when auth.json does not exist - Fix TFA creation for recent image updates
marciomaciel
suggested changes
Mar 8, 2024
There was a problem hiding this comment.
Will be nice if the script automatic check the .env file and identify if it set elasticsearch or opensearch as search engine.
There was a problem hiding this comment.
add elasticsearch setup parameters to INSTALL_FLAGS
| INSTALL_FLAGS="${INSTALL_FLAGS} \ | ||
| --cleanup-database \ | ||
| --backend-frontname=backend \ | ||
| --backend-frontname=admin \ |
There was a problem hiding this comment.
This should probably pair with an issue in the docs repo to update the references to backend.
There was a problem hiding this comment.
Also requires update to line 29
There was a problem hiding this comment.
Should update this repo's readme.md table for AdminURLs all reference backend as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.