Split StarterTemplates to AvailableTemplates #3345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
This was referenced Nov 10, 2025
This was referenced Nov 10, 2025
cprecioso
commented
Nov 10, 2025
| {- HLINT ignore openSaasStarterTemplate "Redundant $" -} | ||
|
|
||
| openSaasStarterTemplate :: StarterTemplate | ||
| openSaasStarterTemplate = |
Member
Author
There was a problem hiding this comment.
This previously used a simpleGhReleaseArchiveTemplate, which was just one more layer that provided little abstraction nor extra functionality, and was only used here. I removed it and now the function creates the structure directly.
cprecioso
commented
Nov 10, 2025
| -- is a no-op, but it exists for future-proofing. And to make consecutive calls | ||
| -- to styleCode and styleText look similar. | ||
| styleText :: String -> String | ||
| styleText = id |
Member
Author
There was a problem hiding this comment.
Extracted this here since it is used in both AvailableTemplates and StarterTemplates, and in this way is colocated with styleCode.
cprecioso
commented
Nov 10, 2025
cprecioso
force-pushed
the
cprecioso/split-starter-templates
branch
from
e04cca1 to
afd25f0
Compare
Deploying wasp-docs-on-main with
|
| Latest commit: |
f5ae87a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ccc695f8.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://cprecioso-split-starter-temp.wasp-docs-on-main.pages.dev |
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
cprecioso
force-pushed
the
cprecioso/split-starter-templates
branch
from
afd25f0 to
a6b2b49
Compare
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
cprecioso
force-pushed
the
cprecioso/split-starter-templates
branch
from
a6b2b49 to
10d6714
Compare
cprecioso
had a problem deploying
to
fly-deploy-test
GitHub Actions
Error
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
cprecioso
force-pushed
the
cprecioso/split-starter-templates
branch
from
ffc7d72 to
f5ae87a
Compare
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
infomiho
reviewed
Nov 27, 2025
Member
infomiho
left a comment
infomiho
left a comment
There was a problem hiding this comment.
The refactor is good, but I think there are some assumptions we can better encode.
waspc/cli/src/Wasp/Cli/Command/CreateNewProject/AvailableTemplates.hs
Outdated
Show resolved
Hide resolved
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of adding one more kind of StarterTemplate (#3338), the
StarterTemplates.hsfile was getting crowded, so I left in this file all the types and definitions, and moved the specifications of available templates to their own file.Connections
open-saasdevelopment version is out of sync withwaspdevelopment version #3073Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests:
I added unit tests for my change.(if you fixed a bug) I added a regression test for the bug I fixed.(if you added/updated a feature) I added/updated e2e tests atexamples/kitchen-sink/e2e-tests.(if you added/updated a feature) I updated the starter templates atwaspc/data/Cli/templates, as needed.📜 Documentation:
(if you added/updated a feature) I added/updated the documentation inweb/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
I updatedwaspc/ChangeLog.mdwith a user-friendly description of the change.(if you did a breaking change) I added a step to the current migration guide atweb/docs/migration-guides/.I bumped theversioninwaspc/waspc.cabalto reflect the changes I introduced.