Skip to content

Improved OSError handling #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved OSError handling #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Terminal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import sublime
import sublime_plugin
import errno
import os
import sys
import subprocess
Expand Down Expand Up @@ -144,9 +145,16 @@ def run_terminal(self, dir_, parameters):
subprocess.Popen(args, cwd=cwd)

except (OSError) as exception:
print(str(exception))
sublime.error_message('Terminal: The terminal ' +
TerminalSelector.get() + ' was not found')
# By default, use and log the message from our error
message = str(exception)
print(message)

# If the terminal wasn't found, then use a better message
if exception.errno == errno.ENOENT:
message = 'Terminal: The terminal ' + TerminalSelector.get() + ' was not found'

# Notify the user of the issue
sublime.error_message(message)
except (Exception) as exception:
sublime.error_message('Terminal: ' + str(exception))

Expand Down