feat(remove): update node_modules/.bin #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and upgrade "husky" to v1.3
Any commands with a --yarn flag will look for a "yarn.lock" file in the working directory. When a lockfile exists, the --yarn flag will be true by default. Other fixes: - actually use argv.yarn for the "link" command - actually use the `getPackageManager` function's argument - remove unused `showVersion` function
Make the `add` and `link` commands update the "node_modules/.bin" directory.
Yalc now looks for the nearest ancestor that contains a package.json file. I also did some tidying up! Fixes wclr#47
Improve the "remove" command by cleaning up after ourselves in the "node_modules/.bin" directory.
|
This PR seems weird, many changes. Won't yarn take care of cleaning up |
|
As I said above, the only commit relevant to this PR is 507ad81. The others are from other PRs that this PR is dependent on. Maybe yarn cleans up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the
removecommand by cleaning up after ourselves in thenode_modules/.bindirectory.The only relevant commit: 507ad81
Improves upon #61
(Probably wanta merge #62 before this)