refactor: "yalc add" flags #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and upgrade "husky" to v1.3
Changes affecting "yalc add": - use --link by default - remove the --file flag (use --no-link instead) - remove the --save-dev flag (use --dev instead) - add --no-save flag Changes affecting the `addPackages` function: - rename "link" option to "noSave" - rename "linkDep" option to "link"
aleclarson
changed the title
aleclarson
added a commit
to aleclarson/yalc
that referenced
this pull request
Jan 18, 2019
|
Note to self: Cherry-pick aleclarson@75c56cf before this is merged. |
aleclarson
added a commit
to aleclarson/yalc
that referenced
this pull request
Jan 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default behavior of
yalc addto link to.yalc/{name}fromnode_modulesinstead of copying the contents of.yalc/{name}. You can use--no-linkto get the old behavior.This is better because it means any breakpoints I set in
.yalc/{name}will be used no matter what; whereas the current behavior ignores those breakpoints if I useyalc addinstead ofyalc link.And once #66 is merged, this commit lets us avoid copying
.yalc/{name}/node_modulestonode_modules/{name}/node_modules.The relevant commit: d7a4f56
(Probably wanta merge #59 first)