Skip to content

chore: use pnpm in package.json scripts #11520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 3, 2025
Merged

chore: use pnpm in package.json scripts #11520

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b6e212
chore: use pnpm in package.json scripts
ahabhgk Aug 28, 2025
6e241fb
chore: use pnpm in package.json scripts
ahabhgk Aug 28, 2025
04c54b2
fix
ahabhgk Aug 28, 2025
fb8960b
Update .husky/pre-commit
chenjiahan Aug 28, 2025
a062efc
Apply suggestions from code review
chenjiahan Aug 28, 2025
5cdee20
use correct rspack
ahabhgk Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
npx lint-staged
pnpm lint-staged
10 changes: 5 additions & 5 deletions crates/rspack_plugin_javascript/src/parser_plugin/import_meta_plugin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,11 @@ impl JavascriptParserPlugin for ImportMetaPlugin {
// import.meta
// warn when access import.meta directly
parser.warning_diagnostics.push(Box::new(create_traceable_error(
"Critical dependency".into(),
"Accessing import.meta directly is unsupported (only property access or destructuring is supported)".into(),
parser.source_file,
span.into()
).with_severity(Severity::Warning)));
"Critical dependency".into(),
"Accessing import.meta directly is unsupported (only property access or destructuring is supported)".into(),
parser.source_file,
span.into(),
).with_severity(Severity::Warning)));

let content = if parser.is_asi_position(span.lo()) {
";({})"
Expand Down
2 changes: 1 addition & 1 deletion lint-staged.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ export default {
"*.rs": "rustfmt",
"*.{ts,tsx,js,mjs,yaml,yml}":
"node ./node_modules/prettier/bin/prettier.cjs --write",
"*.toml": "npx @taplo/cli format",
"*.toml": "pnpx @taplo/cli format",
"*.{ts,tsx,js,cts,cjs,mts,mjs}": [
"pnpm run lint:js",
// ignore staged file list; execute x without extra args
Expand Down
28 changes: 14 additions & 14 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,23 @@
"check-dependency-version": "pnpx check-dependency-version-consistency@5 . --ignore-dep chalk --ignore-package webpack-test --ignore-package webpack-examples",
"build:js": "pnpm --filter \"@rspack/core\" build && pnpm --parallel --filter \"@rspack/*\" --filter \"create-rspack\" --filter \"!@rspack/core\" build",
"build:js:canary": "pnpm --filter \"@rspack-canary/core\" build && pnpm --parallel --filter \"@rspack-canary/*\" --filter \"create-rspack-canary\" --filter \"!@rspack-canary/core\" build",
"build:cli:dev": "npm run build:binding:dev && npm run build:js",
"build:cli:dev:wasm": "pnpm --filter @rspack/binding build:dev:wasm && npm run build:js",
"build:cli:dev:browser": "pnpm --filter @rspack/binding build:dev:browser && npm run build:js",
"build:cli:release": "npm run build:binding:release && npm run build:js",
"build:cli:release:all": "pnpm --filter @rspack/binding build:release:all && npm run build:js",
"build:cli:release:arm64": "pnpm --filter @rspack/binding build:release:arm64 && npm run build:js",
"build:cli:release:x64": "pnpm --filter @rspack/binding build:release:x64 && npm run build:js",
"build:cli:release:linux": "pnpm --filter @rspack/binding build:release:linux && npm run build:js",
"build:cli:release:win": "pnpm --filter @rspack/binding build:release:win && npm run build:js",
"build:cli:release:wasm": "pnpm --filter @rspack/binding build:release:wasm && npm run build:js",
"build:cli:release:browser": "pnpm --filter @rspack/binding build:release:browser && npm run build:js",
"build:cli:dev": "pnpm run build:binding:dev && pnpm run build:js",
"build:cli:dev:wasm": "pnpm --filter @rspack/binding build:dev:wasm && pnpm run build:js",
"build:cli:dev:browser": "pnpm --filter @rspack/binding build:dev:browser && pnpm run build:js",
"build:cli:release": "pnpm run build:binding:release && pnpm run build:js",
"build:cli:release:all": "pnpm --filter @rspack/binding build:release:all && pnpm run build:js",
"build:cli:release:arm64": "pnpm --filter @rspack/binding build:release:arm64 && pnpm run build:js",
"build:cli:release:x64": "pnpm --filter @rspack/binding build:release:x64 && pnpm run build:js",
"build:cli:release:linux": "pnpm --filter @rspack/binding build:release:linux && pnpm run build:js",
"build:cli:release:win": "pnpm --filter @rspack/binding build:release:win && pnpm run build:js",
"build:cli:release:wasm": "pnpm --filter @rspack/binding build:release:wasm && pnpm run build:js",
"build:cli:release:browser": "pnpm --filter @rspack/binding build:release:browser && pnpm run build:js",
"test:js": "pnpm -r run test",
"format:rs": "cargo fmt --all",
"format:js": "pnpm run format-ci:js --write",
"format-ci:js": "node ./node_modules/prettier/bin/prettier.cjs \"packages/**/src/**/*.{ts,tsx,mts,cts,js,mjs,cjs,jsx}\" \"crates/rspack_plugin_runtime/**/*.{ts,js}\" \"scripts/**/*.{cjs,mjs,js}\" \"*.mjs\" \"x\" --check",
"format-ci:toml": "npx @taplo/cli format --check '.cargo/*.toml' './crates/**/Cargo.toml' './Cargo.toml'",
"format:toml": "npx @taplo/cli format '.cargo/*.toml' './crates/**/Cargo.toml' './Cargo.toml'",
"format-ci:toml": "pnpx @taplo/cli format --check '.cargo/*.toml' './crates/**/Cargo.toml' './Cargo.toml'",
"format:toml": "pnpx @taplo/cli format '.cargo/*.toml' './crates/**/Cargo.toml' './Cargo.toml'",
"lint:js": "pnpm run lint-ci:js --write",
"lint-ci:js": "biome check --diagnostic-level=warn --no-errors-on-unmatched --max-diagnostics=none --error-on-warnings",
"lint:rs": "node ./scripts/check_rust_dependency.cjs",
Expand Down Expand Up @@ -102,4 +102,4 @@
"esbuild"
]
}
}
}
2 changes: 1 addition & 1 deletion tests/e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "0.1.8",
"scripts": {
"test": "playwright test",
"test:CI": "CI=1 npm run test"
"test:CI": "CI=1 pnpm run test"
},
"devDependencies": {
"@babel/core": "^7.28.0",
Expand Down
4 changes: 2 additions & 2 deletions x.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ rspackCommand
.action(async ({ debug }) => {
try {
if (!debug) {
await $`npx rspack ${getVariadicArgs()}`;
await $`pnpm rspack ${getVariadicArgs()}`;
return;
}
await launchRspackCli(getVariadicArgs());
Expand Down Expand Up @@ -234,7 +234,7 @@ jestCommand
.argument("[args...]", "Arguments pass through to rspack cli")
.action(async ({ debug }) => {
if (!debug) {
await $`npx jest ${getVariadicArgs()}`;
await $`pnpm jest ${getVariadicArgs()}`;
return;
}
await launchJestWithArgs(getVariadicArgs());
Expand Down
Loading