Skip to content

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Sep 3, 2025

Summary

ref #11520 (comment)

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings September 3, 2025 08:29
Copy link

netlify bot commented Sep 3, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 6337da5
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68b7fc5170045d00085bf795
😎 Deploy Preview https://deploy-preview-11572--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the use of local packages in script execution commands by replacing pnpx with pnpm exec and ensuring dependencies are explicitly listed in package.json files.

  • Replaces pnpx with pnpm exec for consistent local package execution
  • Adds missing dependencies to package.json files to support the local execution approach
  • Reorganizes dependency order in package.json for consistency

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
x.mjs Updates rspack and jest command execution to use pnpm exec
website/package.json Adds case-police and cspell as local dependencies and updates script commands
package.json Adds check-dependency-version-consistency and reorganizes dependencies
lint-staged.config.mjs Updates taplo execution to use pnpm exec
.husky/pre-commit Updates lint-staged execution to use pnpm exec
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 3, 2025
@ahabhgk ahabhgk enabled auto-merge (squash) September 3, 2025 08:29
Copy link
Contributor

github-actions bot commented Sep 3, 2025

📦 Binary Size-limit

Comparing 6337da5 to refactor: use for_name for cjs import parser plugin (#11569) by Gengkun

🎉 Size decreased by 43.50KB from 47.31MB to 47.26MB (⬇️0.09%)

@chenjiahan
Copy link
Member

chenjiahan commented Sep 3, 2025

I've intentionally used pnpx cspell before to reduce npm dependencies and speed up workflow (cspell is only used in specific CI). However, I can accept declaring these dependencies because it makes version management easier.

image

Copy link

codspeed-hq bot commented Sep 3, 2025

CodSpeed Performance Report

Merging #11572 will not alter performance

Comparing use-local-pkg (6337da5) with main (debe22c)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 17 untouched benchmarks

@ahabhgk ahabhgk merged commit 62c4c76 into main Sep 3, 2025
47 checks passed
@ahabhgk ahabhgk deleted the use-local-pkg branch September 3, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants