-
-
Notifications
You must be signed in to change notification settings - Fork 737
ci: remove legacy ecosystem CI yaml #12352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
Rsdoctor Bundle Diff AnalysisFound 5 project(s) in monorepo. 📁 react-10kPath:
📦 Download Diff Report: react-10k Bundle Diff 📁 react-1kPath:
📦 Download Diff Report: react-1k Bundle Diff 📁 react-5kPath:
📦 Download Diff Report: react-5k Bundle Diff 📁 romePath:
📦 Download Diff Report: rome Bundle Diff 📁 ui-componentsPath:
📦 Download Diff Report: ui-components Bundle Diff Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🙈 Size remains the same at 47.70MB |
CodSpeed Performance ReportMerging #12352 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates the ecosystem CI configuration by removing the legacy ecosystem-ci-rstack.yml workflow and migrating its functionality into the main ecosystem-ci.yml file. The changes align with the new rstack-ecosystem-ci infrastructure hosted at https://rstack-ecosystem-ci.netlify.app/.
Key Changes:
- Migrated all functionality from
ecosystem-ci-rstack.ymltoecosystem-ci.ymland deleted the legacy file - Updated repository references from
web-infra-dev/rspack-ecosystem-citorspack-contrib/rstack-ecosystem-ci - Added
--stack rspackparameter to ecosystem CI test commands to work with the new multi-stack CI system
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/ecosystem-ci-rstack.yml | Deleted the legacy rstack-specific ecosystem CI workflow (354 lines removed) |
| .github/workflows/ecosystem-ci.yml | Updated with rstack functionality including new test suites (rsdoctor, nuxt, devserver), repository URL changes to rspack-contrib, --stack rspack parameters, and the publish-ecosystem-history job for tracking CI results |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
chenjiahan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Summary
the new ecosystem CI yaml already works and Rspack ecosystem CI status can be tracked on https://rstack-ecosystem-ci.netlify.app/.
remove the legacy yaml and rename
.github/workflows/ecosystem-ci-rstack.ymlto.github/workflows/ecosystem-ci.yml.Related links
Checklist