Skip to content

External texture #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

External texture #192

wants to merge 2 commits into from

Conversation

Kangz
Copy link
Collaborator

@Kangz Kangz commented Jun 5, 2023

FYI @litherum @cwfitzgerald

The external texture descriptor is pretty Dawn-specific but the rest seems like it could be shared easily. WDYT?

@litherum
Copy link

litherum commented Jun 12, 2023

  • Should probably say that this fixes ExternalTexture support #188
  • I think most of WGPUExternalTextureDescriptor is Dawn-specific, so it probably should be moved into a chained struct, rather than being in the top-level WGPUExternalTextureDescriptor struct. For comparison, our implementation of WGPUExternalTextureDescriptor is much simpler. Also, for us, we can use the platform-specific CVPixelBufferRef which includes a lot of the metadata within itself.

Other than the above, this looks awesome; thanks for adding support!

@kainino0x kainino0x mentioned this pull request Oct 12, 2023
1 task
@kainino0x kainino0x added the non-breaking Does not require a breaking change (that would block V1.0) label Oct 12, 2023
@Kangz Kangz mentioned this pull request Mar 31, 2025
@kainino0x kainino0x marked this pull request as draft May 1, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking Does not require a breaking change (that would block V1.0)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants