-
Notifications
You must be signed in to change notification settings - Fork 341
Use GPUBuffer in GPUBindingResource #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use GPUBuffer in GPUBindingResource #514
Conversation
FYI It requires gpuweb/types#182 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but marking draft as we need to wait until all browsers support this.
Thanks for this PR. I like this new style! Agree with @kainino0x, we shouldn't merge this until all browsers support it and it's shipped in Chrome stable, and maybe given it 2+ weeks or after that. |
@jimblandy @mwyrzykowski Are there existing browser bugs/tickets I can follow to keep track of those changes? |
Yes, WebKit bug is https://bugs.webkit.org/show_bug.cgi?id=294006 @beaufortfrancois |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Spec PR: gpuweb/gpuweb#5193