Always visible toolbar #5778
Merged
Always visible toolbar #5778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viljen789
approved these changes
Oct 27, 2025
Contributor
Viljen789
left a comment
Viljen789
left a comment
There was a problem hiding this comment.
Not sure if we moved away from using vh, but really nice change anyways! Looks much better!
Contributor
Author
I understand... but don't see what other unit or solution would be good for both mobile and laptop viewport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solution for webkom/lego#3837 (comment). Instead of making the toolbar sticky, I opted to make the content-box scrollable with a max-height. Now the toolbar does not get pushed outside your viewport. A sticky toolbar would also look kinda awkward🤷♂️
Btw, toolbar component code is very cool!
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Caution
Make sure your images do not contain any real user information.
Screen.Recording.2025-10-27.at.19.55.15.mov
Screen.Recording.2025-10-27.at.19.52.58.mov
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ABA-1472