Skip to content

Conversation

@clarkdo
Copy link

@clarkdo clarkdo commented Oct 6, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add disconect on EventSourceWrapper for making close eventSource manually possible.

Breaking Changes

Additional Info

@glenjamin
Copy link
Collaborator

This code appears correct, but could you describe a use-case which would motivate doing this?

@clarkdo
Copy link
Author

clarkdo commented Oct 6, 2019

My case is that I want to close connection if the browser tab is hidden or minimized and refresh page when tab gets activated again for preventing reaching connection limitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants