-
-
Notifications
You must be signed in to change notification settings - Fork 56
Move crawl and QA logs to new mongo collection #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
902a347
to
2ebc399
Compare
tw4l
commented
Aug 6, 2025
ikreymer
reviewed
Aug 13, 2025
ikreymer
reviewed
Aug 13, 2025
Co-authored-by: Ilya Kreymer <[email protected]>
… setting to null, remove from internal model, only keep in output as deprecated
ikreymer
approved these changes
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! (Just made some minor changes to remove the unused fields, left only the out fields as deprecated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2765
(This is a necessary part of ensuring mongo documents don't exceed 16MB. Hopefully it's also sufficient but we'll need to see in practice if there are other fields that need to be separated out.)
This PR moves crawl and QA run logs into a separate
crawl_logs
mongo collection.It adds a new backend module (without a distinct API router, but the crawls module is getting quite large and it seemed to make sense to add a separate module for the new mongo collection), as well as a migration to move crawl logs from
Crawl
objects into the new collection. The existing nightly test for crawl error logs is fleshed out, and a new nightly test added for behavior logs.The migration has been tested locally. I've also verified that the new collection's indices are used by the existing crawl error and behavior log endpoints.