This repository was archived by the owner on Apr 22, 2020. It is now read-only.
in our automation (bamboo/reggie) PersistentCaching is disabled due to some long forgotten bug, #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly for now where we disable it in our automation due to some unresolved bugs. When those are resolved we can turn it back on, although it is mainly for the benefit of users, not the volatile automation env.
idanarye
reviewed
Nov 15, 2018
| return ret | ||
|
|
||
| inner = timecache(expiration=self.expiration)(inner) | ||
| self._timecache_clear = inner.cache_clear |
There was a problem hiding this comment.
Maybe I'm not following this correctly, but wouldn't this override self._timecache_clear to be the cache_clear of the last returned cache? If the PersistentCache is called multiple times, clear() will only clear the cache of the last call?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and we need this to get some caching going at least within the process ('_get_instance_types_meta', for example)