Skip to content

Avoid passing null through to 'valid name prefix' #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

shannonbooth
Copy link
Member

@shannonbooth shannonbooth commented Jul 2, 2025

Fixes #1387

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@annevk annevk requested a review from domenic July 2, 2025 13:35
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is worth merging as it just fixes a very clear spec bug, even if we still want to discuss further potential spec fixes in #1387, and the tests are not yet perfectly aligned with the current spec.

annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 9, 2025
@annevk annevk merged commit 1b4bd48 into whatwg:main Jul 9, 2025
2 checks passed
@annevk
Copy link
Member

annevk commented Jul 9, 2025

Thank you!

lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request Jul 14, 2025
…M spec, a=testonly

Automatic update from web-platform-tests
DOM: correct validate and extract tests

See whatwg/dom#1387 and whatwg/dom#1388 for context.

Fixes #53464.
--

wpt-commits: 3f4bd80a4b333cd3be5ad0b69aa89d8094c78d2b
wpt-pr: 53533
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Jul 15, 2025
…M spec, a=testonly

Automatic update from web-platform-tests
DOM: correct validate and extract tests

See whatwg/dom#1387 and whatwg/dom#1388 for context.

Fixes #53464.
--

wpt-commits: 3f4bd80a4b333cd3be5ad0b69aa89d8094c78d2b
wpt-pr: 53533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Misalignment between spec and WPT for "validate and extract"
3 participants