Skip to content
This repository was archived by the owner on May 3, 2021. It is now read-only.

Conversation

@rubdos
Copy link
Member

@rubdos rubdos commented May 30, 2020

Updates dependencies and fixes #55

Feel free to cherry-pick 4755218 if you'd rather keep Cargo.lock!

@rubdos
Copy link
Member Author

rubdos commented May 30, 2020

It looks like a transitive dependency uses ptr_cast, which is stabilized in 1.38. Should the minimum Rust version be pushed up?

@Michael-F-Bryan
Copy link
Contributor

I think we're at Rust 1.43.1 at the moment, so bumping the MSRV to 1.38 is fair enough.

Make sure you update this comment noting which feature our MSRV depends on.

@Michael-F-Bryan
Copy link
Contributor

Would you be able to do a git submodule update --remote while you're at it? It looks like they did a small bugfix to stop a leak. When the PR lands I'll make a new libsignal-protocol-sys release so the fixed code is on GitHub.

rubdos added 3 commits May 31, 2020 09:48
This requires bumping the minimum Rust version to 1.38, since a
transitive dependency depends on the `ptr_cast` feature.
@rubdos rubdos force-pushed the dependency-update branch from 4732ff3 to b9b10d7 Compare May 31, 2020 07:49
@rubdos
Copy link
Member Author

rubdos commented May 31, 2020

Melded the Rust update in the dependency update (since those go hand-in-hand), added a bump to libsignal-c in a separate commit.

@Michael-F-Bryan Michael-F-Bryan merged commit 7f2d312 into whisperfish:master May 31, 2020
@rubdos rubdos deleted the dependency-update branch May 31, 2020 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider removing Cargo.lock

2 participants